Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix infra-scan-pipeline missing image #231

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Fix infra-scan-pipeline missing image #231

merged 1 commit into from
Aug 22, 2024

Conversation

bitkeks
Copy link
Member

@bitkeks bitkeks commented Aug 21, 2024

No description provided.

@bitkeks bitkeks requested a review from 90n20 August 21, 2024 13:09
@bitkeks
Copy link
Member Author

bitkeks commented Aug 21, 2024

@maxwolfs something to have a look at..

@jschoone
Copy link
Contributor

We stuck at the same problem which seems to be fixed with this PR

@bitkeks bitkeks merged commit caf799d into main Aug 22, 2024
3 checks passed
@bitkeks bitkeks deleted the bitkeks-patch-1 branch August 22, 2024 06:01
@bitkeks
Copy link
Member Author

bitkeks commented Aug 22, 2024

This is more of a quickfix, we should look at it again with @maxwolfs:

  1. The best option is to not limit source to *.md, but copy the whole directory. But this fails, if one of the Markdown files has issues in rendering
  2. Another option is to then give a list of specific files to copy, "source": ["docs/*.md", "docs/images/*.png"]. But this will break paths, because the images will be in the same directory level as the .md, breaking relative paths.
  3. Third option is to use option 1 but enforcing that included documents are all compatible with Docusaurus. This will always fall back on the people from the upstream repos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants